Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: move es6-shim to core-js (new stuff only) #853

Closed
wants to merge 1 commit into from

Conversation

hansl
Copy link
Contributor

@hansl hansl commented May 19, 2016

Fixes #851.

filipesilva pushed a commit that referenced this pull request Jun 1, 2016
@filipesilva
Copy link
Contributor

@hansl core-js also includes reflect-metadata, I tested it myself. Can you remove it as well in this PR?

@Shyam-Chen
Copy link
Contributor

Hello, I would like to help you for this.

@briananderson1222
Copy link

👍 This is essential for working with IE

@briananderson1222
Copy link

Any reason this is being held up?

For those who are having major slow-downs on IE9-11 I ended up removing es6-shim and reflect-metadata, adding core-js (including in the vendorNpmFiles array), and adding the following to the angular-cli-build.js file after the vendorNpmFiles array.

polyfills: [
      'vendor/core-js/client/shim.min.js',
      'vendor/systemjs/dist/system.src.js',
      'vendor/zone.js/dist/zone.js'
    ]

been running this setup for almost a month now with no issues and extreme performance enhancements in IE9-11

@coryrylan
Copy link
Contributor

coryrylan commented Jun 25, 2016

@filipesilva (updated) if this pull request is stale I'd like to take a shot at getting a PR in and get reflect-metadata removed.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from es6-shim to core-js/client/shim
5 participants