-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular/cli): Generating component considers default style ext #7648
Conversation
…sion for project now
@filipesilva , @Brocco , @hansl , can you please review this? I think I fixed #7522 too with this. |
Are there any unit tests for this? |
@avatsaev Added unit test for the use case. Though I do need to discuss about use cases where we want to do the |
@AhsanAyaz that's great! Just be aware there is a commit message format, "Added unit-test" probably won't pass, must be something like "test (generate): add unit tests for styles extension" |
@avatsaev Yeah watched the build failing. Really hurts. lol |
@Brocco thanks for reviewing earlier. |
Awesome! |
Awesome! Can i meet this at next version release? |
Hi, in what version was this landed? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #7624, #7644, #7647, #7708, #7715, #7719, #7721 & #7522