Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): fix problem of SuppressPlugin in case entryFiles type is string #7393

Merged
merged 2 commits into from
Aug 17, 2017
Merged

fix(@angular/cli): fix problem of SuppressPlugin in case entryFiles type is string #7393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
925b1fc
fix(@angular/cli): fix problem of SuppressPlugin in case entryFiles t…
dcalsky Aug 15, 2017
4467838
style(@angular/cli): add missed semi-colons and format code indent fo…
dcalsky Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/@angular/cli/plugins/suppress-entry-chunks-webpack-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,17 @@ export class SuppressExtractedTextChunksWebpackPlugin {
compiler.plugin('compilation', function (compilation: any) {
// find which chunks have css only entry points
const cssOnlyChunks: string[] = [];
const entryPoints = compilation.options.entry;
// determine which entry points are composed entirely of css files
for (let entryPoint of Object.keys(entryPoints)) {
if (entryPoints[entryPoint].every((el: string) =>
el.match(/\.(css|scss|sass|less|styl)$/))) {
cssOnlyChunks.push(entryPoint);
}
const entryPoints = compilation.options.entry;
// determine which entry points are composed entirely of css files
for (let entryPoint of Object.keys(entryPoints)) {
let entryFiles: string[]|string = entryPoints[entryPoint];
// when type of entryFiles is not array, make it as an array
entryFiles = entryFiles instanceof Array ? entryFiles : [entryFiles];
if (entryFiles.every((el: string) =>
el.match(/\.(css|scss|sass|less|styl)$/) !== null)) {
cssOnlyChunks.push(entryPoint);
}
}
// Remove the js file for supressed chunks
compilation.plugin('after-seal', (callback: any) => {
compilation.chunks
Expand Down