Support enhanced resolve #7169
Merged
Support enhanced resolve #7169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
approved these changes
Jul 27, 2017
filipesilva
added a commit
that referenced
this pull request
Jul 27, 2017
* fix(@ngtools/webpack): support [email protected] Followup to #7123 * fix(@angular/cli): unpin webpack 3.3.0 Followup to #7130
filipesilva
added a commit
that referenced
this pull request
Jul 27, 2017
* fix(@ngtools/webpack): support [email protected] Followup to #7123 * fix(@angular/cli): unpin webpack 3.3.0 Followup to #7130
|
@filipesilva 👋 , thank you for your responsiveness on this. Made a world of difference for our team! |
Closed
|
Hey @burtonjc, just wanted to say it makes me really happy to hear that! It's obviously important to me that our stuff is working correctly and fulfilling it's purpose, but comments like yours never fail to put a happy smile on my face and leaving me feeling good for a fair bit. Cheers! |
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 22, 2017
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 22, 2017
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 22, 2017
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 22, 2017
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 23, 2017
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 23, 2017
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Aug 23, 2017
hansl
pushed a commit
that referenced
this pull request
Aug 23, 2017
hansl
pushed a commit
that referenced
this pull request
Aug 25, 2017
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
* fix(@ngtools/webpack): support [email protected] Followup to angular#7123 * fix(@angular/cli): unpin webpack 3.3.0 Followup to angular#7130
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary hack to address these two issues:
This way we set values correctly in both a Map (enhanced-resove>=3.4.0) and object (enhanced-resolve >= 3.1.0 <3.4.0).
The right solution is to create a virtual filesystem by decorating the filesystem, instead of injecting data into the private cache of the filesystem.
Doing it the right way should fix other related bugs, but meanwhile we hack it since: