Add support for minifying index.html

[ishitatsuyuki]

This was built with compatibility in mind.

[ishitatsuyuki]

Travis spurious error. Please trigger a rebuild.

[dave11mj]

@ishitatsuyuki you can trigger a rebuilt by git push -f it also gives you the chance to rebase your branch so its up to date with master ~ ^^

[ishitatsuyuki]

Two weeks elapsed. Please take a look!

[filipesilva]

Heya @ishitatsuyuki, old system are used with the CLI, and we really don't want to introduce breaking changes for such little benefit. I'm sorry, but I'll have to close this PR.

[ishitatsuyuki]

@filipesilva I'm aware of such concerns. Actually, I'm willing to disable the removal of trailing slash (it can be specified as keepTrailingSlash, if it's going to keep compatibility with (really) old XHTML engines.

It's a tradeoff of compatibility with performance, though. If you reopened this, I will change it to allow XHTML ASAP.

[filipesilva]

I don't quite get what the problem is that you're trying to solve though. Is there a bug currently that you're trying to fix?

[ishitatsuyuki]

#1861

[filipesilva]

Ah I see now! I'll reopen, and thank you for taking such an old issue on.

I'm slightly worried that it might affect some users that are currently depending on the current index.html format, but that's a matter for discussion. We're also thinking of adding a --minify flag so this could be controlled there for less disruption.

As for this PR as is, can you change it to not remove xhtml, and thus not change the other files? Your changes to packages/@angular/cli/tasks/eject.ts are just whitespace changes as well, and we normally don't allow that in PRs (it's just back and forth on file that don't need to change).

[ishitatsuyuki]

Looks like there's some presumably spurious build failures. Please trigger a rebuild and see if there is a real problem or not.

[clydin]

Some performance data if anyone is curious.

File size differences for a new project:

Minified	Raw (bytes)	Gzip (bytes)
No	701	377
Yes	674	365
Change	-27 (~4%)	-12 (~3%)

For a medium-size project with some additional index content:

Minified	Raw (bytes)	Gzip (bytes)
No	1163	550
Yes	1121	532
Change	-42 (~4%)	-18 (~3%)

[filipesilva]

Why is cache set to false?

[ishitatsuyuki]

Looks like a leftover from the inlining implementation. Will remove it.

[filipesilva]

Restarted builds.

[clydin]

might want to adjust the commit message to indicate this just minifies index.html.

[ishitatsuyuki]

Review?

[clydin]

It looks like version 3.0 of the HtmlWebpackPlugin will remove built-in support for minification. Not sure on the timeline though.

[ishitatsuyuki]

Semver will still protect us, and I believe someone will create a plugin to bring the functionality. If nobody do, maybe I will do that.

:( so slow review, it's going to enter the refactor cycle

[filipesilva]

Sorry for the delay in getting it merged, I'm doing it now.

[icorne]

Is there any way we can still get the trailing slash? Or to disable the minification of just the index.html?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}