fix(@ngtools/webpack): diagnose generated files and resolve sourcemaps #5601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated files were not diagnosed in AOT which led to errors not being shown properly. Also, in order to show the proper error source we now resolve the sourcemap of any errors we find. Fixes angular#5264 Fixed angular#4538
filipesilva
approved these changes
Mar 23, 2017
This was referenced Mar 24, 2017
|
Look very much forward to a fix. Looks like it would solve angular/angular#15663 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated files were not diagnosed in AOT which led to errors not being shown properly. Also, in order to show the proper error source we now resolve the sourcemap of any errors we find.