fix(@angular/cli): ensure lint generates well-formed machine output #5224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumitarora
reviewed
Mar 7, 2017
packages/@angular/cli/tasks/lint.ts
Outdated
| @@ -6,6 +6,7 @@ import { requireProjectModule } from '../utilities/require-project-module'; | |||
| import { CliConfig } from '../models/config'; | |||
| import { LintCommandOptions } from '../commands/lint'; | |||
| import { oneLine } from 'common-tags'; | |||
| // import * as tslint from 'tslint'; | |||
There was a problem hiding this comment.
Please remove commented code
sumitarora
reviewed
Mar 7, 2017
| if (current.fixes) { | ||
| total.fixes = (total.fixes || []).concat(...current.fixes); | ||
| } | ||
| return total; |
There was a problem hiding this comment.
Can we just change it to 1 Liner total.fixes = (total.fixes || []).concat(...(current.fixes || [])); 😉
There was a problem hiding this comment.
Originally had a one-liner but some of the built-in formatters expect fixes to be falsy if none were made.
sumitarora
suggested changes
Mar 7, 2017
filipesilva
approved these changes
Mar 8, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
For machine readable output formats, ng lint was concatenating multiple documents into a single file. This resulted in invalid JSON, XML, etc. The lint results are now aggregated and one full output is generated. Fix angular#5259 Close angular#5224
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For machine readable output formats,
ng lintwas concatenating multiple documents into a single file. This resulted in invalid JSON, XML, etc. The lint results are now aggregated and one full output is generated.Fix #5259