feat(@angular/cli): ng e2e defaults to random port #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `ng e2e` will use a random port for serving by default instead of using 4200.
filipesilva
force-pushed
the
e2e-port-auto
branch
from
9685dde to
a2dde7f
Compare
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
BREAKING CHANGE: `ng e2e` will use a random port for serving by default instead of using 4200.
| .then((foundPort: number) => { | ||
|
|
||
| // If the port isn't available and we weren't looking for any port, throw error. | ||
| if (port !== foundPort && port !== 0) { |
There was a problem hiding this comment.
I wonder why you did not just return the found port instead of throwing an error. This would help developers in case the port is already in use, I work with multiple projects at the same time and often find my self having to serve with a random port number. For example ng serve --port=2010
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.