fix(@ngtools/webpack): one star replacement should be preceded by slash

[hccampos]

When building a project with AoT enabled, I noticed that .spec.ts files were not being excluded properly. This was happening because the pattern **/*.spec.ts triggered the two-stars replacement:

"**/*.spec.ts".replace(/\*\*/g, '(?:.*)')
--> "(?:.*)/*.spec.ts"

And then the one star replacement would replace the * inserted by the previous replacement:

"(?:.*)/*.spec.ts".replace(/\*/g, '(?:[^/]*)')
"(?:.(?:[^/]*))/(?:[^/]*).spec.ts"

With this PR, the single-star replacement expects a slash before the star, i.e. /*.spec.ts, so:

"(?:.*)/*.spec.ts".replace(/\/\*/g, '(?:[^/]*)')
"(?:.*)(?:[^/]*)\.spec\.ts"

Which then properly excludes the spec files. This doesn't handle the case where the pattern is in the form of **/something-*.spec.ts, but I am not sure that is super common.

Since I am not super familiar with the codebase, If you guys know of a simpler or better way to fix this problem, I'd welcome feedback. Or feel free to implement/refactor yourselves.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

[hccampos]

Nope, looks like @googlebot is still not happy @filipesilva

[googlebot]

CLAs look good, thanks!

[hccampos]

Yay, now it is finally happy :)

[filipesilva]

Followup from #4455

[hansl]

LGTM

[hansl]

Actually xi18n needs this change as well.

[filipesilva]

Superseded by #4868, which allows user provided excludes and adds them to tsconfig proper.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}