feat(test): extend karma.conf.js w/ kjhtml reporter #4567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardbell
added a commit
to IdeaBlade/angular
that referenced
this pull request
Feb 10, 2017
See related [PR 4567](angular/angular-cli#4567) in `angular-cli`
Closed
3 tasks
wardbell
added a commit
to IdeaBlade/angular
that referenced
this pull request
Feb 13, 2017
See related [PR 4567](angular/angular-cli#4567) in `angular-cli`
|
I think it would be a better reporter than just having a blank screen. |
filipesilva
suggested changes
Feb 14, 2017
| @@ -31,8 +35,8 @@ module.exports = function (config) { | |||
| environment: 'dev' | |||
| }, | |||
| reporters: config.angularCli && config.angularCli.codeCoverage | |||
| ? ['progress', 'karma-remap-istanbul'] | |||
| : ['progress'], | |||
| ? ['progress', 'karma-remap-istanbul'] //, 'kjhtml'] | |||
There was a problem hiding this comment.
LGTM aside from the leftoever comment.
|
LGTM |
wardbell
force-pushed
the
karma-conf-add-kjhtml
branch
from
f6da259 to
7d78f4a
Compare
filipesilva
approved these changes
Feb 14, 2017
wardbell
force-pushed
the
karma-conf-add-kjhtml
branch
3 times, most recently
from
0ba7345 to
2709911
Compare
karma-jasmine-html-reporter (kjhtml) displays Jasmine test runner in the test browser.
wardbell
force-pushed
the
karma-conf-add-kjhtml
branch
from
2709911 to
429b0d2
Compare
|
will it be possible to view the report at a later point in time ? (like the coverage reports) As part our CI, we have to run our unit tests using 'Phantom JS' & we would like to review the results later |
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
karma-jasmine-html-reporter (kjhtml) displays Jasmine test runner in the test browser. Close angular#4567
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add karma-jasmine-html-reporter (kjhtml) which displays Jasmine test runner in the test browser.
We use this in docs testing chapter so users can visualize their tests in the test browser rather than see a blank page. Convenient for exploring broken tests and re-running certain specific tests.
Has no apparent ill-effects on CI. We run these tests with this config in docs CI.
Deliberately excluded from the test/code-coverage combo ... for no great reason other than I thought someone who was running with code-coverage wouldn't want it.