-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): add --poll
option to build/serve/test commands
#4268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the extra doc change.
docs/documentation/build.md
Outdated
@@ -94,3 +94,5 @@ or `ng serve --prod` will also make use of uglifying and tree-shaking functional | |||
`--extract-css` (`-ec`) extract css from global styles onto css files instead of js ones | |||
|
|||
`--output-hashing` define the output filename cache-busting hashing mode | |||
|
|||
`--poll` enable and define the file watching poll time period (milliseconds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this flag to the serve doc as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test in https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/build/rebuild.ts#L20 should also be added. Rebuilds should be triggered with --poll
without touching files.
--poll
option to build/serve commands--poll
option to build/serve/test commands
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This also updates
build --watch
to use the poll setting if present.Closes #4255