Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add --poll option to build/serve/test commands #4268

Closed
wants to merge 2 commits into from
Closed

feat(build): add --poll option to build/serve/test commands #4268

wants to merge 2 commits into from

Conversation

clydin
Copy link
Member

@clydin clydin commented Jan 28, 2017

This also updates build --watch to use the poll setting if present.

Closes #4255

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the extra doc change.

@@ -94,3 +94,5 @@ or `ng serve --prod` will also make use of uglifying and tree-shaking functional
`--extract-css` (`-ec`) extract css from global styles onto css files instead of js ones

`--output-hashing` define the output filename cache-busting hashing mode

`--poll` enable and define the file watching poll time period (milliseconds)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this flag to the serve doc as well?

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test in https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/build/rebuild.ts#L20 should also be added. Rebuilds should be triggered with --poll without touching files.

@clydin clydin changed the title feat(build): add --poll option to build/serve commands feat(build): add --poll option to build/serve/test commands Jan 28, 2017
@clydin clydin deleted the build-watch-poll branch March 29, 2017 14:05
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add poll flag to build/serve/test
3 participants