Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): remove lint option from test command #4261

Merged
merged 1 commit into from Jan 30, 2017
Merged

refactor(test): remove lint option from test command #4261

merged 1 commit into from Jan 30, 2017

Conversation

clydin
Copy link
Member

@clydin clydin commented Jan 28, 2017

As discussed in #4114.

Closes #4114
Closes #3317

BREAKING CHANGE: ng test no longer has the --lint flag available.

@filipesilva
Copy link
Contributor

@clydin I added the BREAKING CHANGE section to your PR message so that it appears on the changelog.

I merged #4260 which contained your types fix so you should be able to get a CI run now.

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the mention from https://github.com/angular/angular-cli/blob/master/docs/documentation/test.md ?

Other than that LGTM (assuming tests pass).

BREAKING CHANGE: ng test no longer has the --lint flag available.
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong PR to comment, nvm!

@hansl hansl merged commit 645c870 into angular:master Jan 30, 2017
@clydin clydin deleted the no-test-lint branch January 31, 2017 12:23
wnodom added a commit to wnodom/angular-cli that referenced this pull request Feb 6, 2017
Delete reference to the `--lint` flag recently removed from
the `ng test` command.

Related to issue angular#4114 and PR angular#4261
hansl pushed a commit that referenced this pull request Feb 7, 2017
Delete reference to the `--lint` flag recently removed from
the `ng test` command.

Related to issue #4114 and PR #4261
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
BREAKING CHANGE: ng test no longer has the --lint flag available.
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
Delete reference to the `--lint` flag recently removed from
the `ng test` command.

Related to issue angular#4114 and PR angular#4261
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
Delete reference to the `--lint` flag recently removed from
the `ng test` command.

Related to issue angular#4114 and PR angular#4261
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: remove --lint flag from ng test Lint script in package.json is ignored
5 participants