Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ember-addon keyword from package.json #4130

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Jan 20, 2017

Searching for "ember-addon" on npmjs.org shows the angular-cli package due to it being declared in the keywords.

screen shot 2017-01-20 at 14 44 35

This PR changes the keywords to be Angular specific so this stops happening. Cheers!

Searching for "ember-addon" on npmjs.org shows the `angular-cli` package due to it being declared in the `keywords`.

<img width="1440" alt="screen shot 2017-01-20 at 14 44 35" src="https://cloud.githubusercontent.com/assets/7525670/22151653/42caf7be-df1f-11e6-9715-bb1543d76836.png">

This PR changes the keywords to be Angular specific so this stops happening. Cheers!
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mxstbr
Copy link
Contributor Author

mxstbr commented Jan 20, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@Brocco Brocco merged commit f4b5773 into angular:master Jan 20, 2017
@mxstbr mxstbr deleted the patch-1 branch January 20, 2017 15:32
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
Searching for "ember-addon" on npmjs.org shows the `angular-cli` package due to it being declared in the `keywords`.

<img width="1440" alt="screen shot 2017-01-20 at 14 44 35" src="https://cloud.githubusercontent.com/assets/7525670/22151653/42caf7be-df1f-11e6-9715-bb1543d76836.png">

This PR changes the keywords to be Angular specific so this stops happening. Cheers!
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants