-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial support for support jade/pug templates #4109
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Note: comments after my first post until the googlebot post appear to be from my own repo from a few months ago. Feel free to ignore them. Edit: I can reproduce the CI failure at |
Just to confirm. I do accept my commits to be contributed to Angular CLI ;) @tycho01 I'll try to get active, just that I work until night and I'm left too exhausted for the weekends. But I'll try to help wrap this up. |
Sure, that works for me :), I suppose I've been sufficiently excited about getting initial support in I wouldn't mind helping out where possible. |
We run pug-cli alongside ng start, so it has been low on priority for our team. |
Closing, please see #1886 (comment) for context. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is an attempt to continue the existing PR 2205 in the absence of its creator, ShadowManu. The scope of the original PR has been left intact here, though I've attempted to add some rudimentary documentation/tests as had been requested of the original PR.