Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: New command 'set' and 'get' to play with the cli config. #407

Merged
merged 1 commit into from
Apr 14, 2016

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Apr 8, 2016

Includes design doc.

* Where in my directory is my karma.conf file?
* What is my firebase database URL?
* Where is my client code?
* How can I use a different
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot something after 'a different'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@filipesilva
Copy link
Contributor

Can you add a few tests?

@hansl
Copy link
Contributor Author

hansl commented Apr 8, 2016

This is a Proof of Concept, @jkuri will do the real code. This is just to get him started :)

description: 'Set a value in the configuration.',
works: 'outsideProject',

availableOptions: [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a global option ?


## CLI

#### Getting values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When getting values from within the CLI the options object should be exposed via the already existing project object. This will have the benefit of not having to require/import in the configuration object from many different places within the CLI. From commands/tasks/generate blueprints, I would like to see the ability to do the following:

var mySetting = this.project.ng.mySetting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jkuri
Copy link
Contributor

jkuri commented Apr 14, 2016

@hansl whats the status of this PR, is this still a work in progress?

});

module.exports = SetCommand;
module.exports.overrideCore = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to override this command as it doesn't exists in ember-cli. That also stands for get.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah 👍 thanks.

@hansl hansl merged commit 8f8af24 into angular:master Apr 14, 2016
@hansl hansl deleted the ng-config branch April 14, 2016 22:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants