-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: New command 'set' and 'get' to play with the cli config. #407
Conversation
* Where in my directory is my karma.conf file? | ||
* What is my firebase database URL? | ||
* Where is my client code? | ||
* How can I use a different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot something after 'a different'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Can you add a few tests? |
This is a Proof of Concept, @jkuri will do the real code. This is just to get him started :) |
description: 'Set a value in the configuration.', | ||
works: 'outsideProject', | ||
|
||
availableOptions: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there be a global
option ?
|
||
## CLI | ||
|
||
#### Getting values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When getting values from within the CLI the options object should be exposed via the already existing project object. This will have the benefit of not having to require/import in the configuration object from many different places within the CLI. From commands/tasks/generate blueprints, I would like to see the ability to do the following:
var mySetting = this.project.ng.mySetting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Includes design doc.
@hansl whats the status of this PR, is this still a work in progress? |
}); | ||
|
||
module.exports = SetCommand; | ||
module.exports.overrideCore = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to override this command as it doesn't exists in ember-cli
. That also stands for get
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah 👍 thanks.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Includes design doc.