fix(generate): correct component path when module is generated in subfolder, and parent folder is not a module too

[Meligy]

fixes #3255

Another attempt at using the correct component name / path when generating modules, that takes care of the special case in #3255.

Existing behaviour that this PR fixes

if you ng g module parent --routing, you can ng g module parent/child --routing.

But if src/app/parent is just a normal folder, the component generation for ng g module parent/child fails.

To test the PR:

• Create a new project linked to the CLI from the PR branch
• Inside the project, run ng g module normal-case --routing to ensure basic scenario is not broken
• Then also run ng g module parent and ng g module parent/child --routing to ensure this scenario is not broken too
• Then run mkdir src/app/parent-folder, and then ng g module parent-folder/child-module --routing to test that this PR does what it promises to do

Or alternatively look at the provided tests in the PR and existing tests, and ensure they cover all above scenarios, and are passing in CI.

Note

This is maybe the 3rd or so attempt at getting this path to work in all scenarios. We are protected by tests though, and we keep adding more tests the more scenarios we get. Let's see if this becomes the last change of this path/name.

[hansl]

Could you also add an e2e test? Acceptance tests are good but likely to be removed after 1.0 but e2e will remain.

[hansl]

LGTM, all that's missing would be an additional e2e test, as noted above.

[Meligy]

@hansl Added e2e test

[Meligy]

e2e test is passing now.

[hansl]

LGTM. Need @Brocco's approval.

[Brocco]

typo? rename please.

dmouleDir -> moduleDir

Also, please rebase and then it can be merged.

[Meligy]

Done.

[Meligy]

Can we mark this for merge now?

Cheers,

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}