feat(serve): Persist serve options in angular-cli.json #3908
Conversation
|
|
delasteve
force-pushed
the
feature/persist-ng-serve-options
branch
3 times, most recently
from
e1211e5 to
c80108c
Compare
| }; | ||
| serve?: { |
There was a problem hiding this comment.
This block was the only thing truly added. The rest was whitespace reindentation (editorconfig).
There was a problem hiding this comment.
This is because generating the schema.d.ts is not done manually. You need to run npm run build-config-interface.
There was a problem hiding this comment.
Now I see the $comment! Thanks 😄
| }; | ||
| serve?: { |
There was a problem hiding this comment.
This is because generating the schema.d.ts is not done manually. You need to run npm run build-config-interface.
| const defaultPort = process.env.PORT || 4200; | ||
| const defaultLiveReloadPort = config.get('defaults.serve.liveReloadPort') || 49152; | ||
| const defaultPort = process.env.PORT || config.get('defaults.serve.port'); | ||
| const defaultHost = config.get('defaults.serve.host') || 'localhost'; |
There was a problem hiding this comment.
config.get should be avoided in the code. It removes typing information as it returns any.
| @@ -54,6 +54,11 @@ | |||
| "module": false, | |||
| "pipe": true, | |||
| "service": true | |||
| }, | |||
| "serve": { | |||
There was a problem hiding this comment.
Since you already have good default values, those are not needed and just add noise to this file. I'd like the default config to grow slimmer.
delasteve
force-pushed
the
feature/persist-ng-serve-options
branch
3 times, most recently
from
7062118 to
8baa45e
Compare
delasteve
changed the title
delasteve
force-pushed
the
feature/persist-ng-serve-options
branch
2 times, most recently
from
f92bf97 to
339c8b5
Compare
|
@hansl can you re-review? |
delasteve
force-pushed
the
feature/persist-ng-serve-options
branch
7 times, most recently
from
81206d7 to
0905cff
Compare
| "type": "object", | ||
| "properties": { | ||
| "port": { | ||
| "type": "number", |
There was a problem hiding this comment.
We need to add description for all new properties. We're going to do a full run through existing ones, but new properties should have proper descriptions. This is because we're going to add support for IDEs that support schema, and those descriptions will be shown to users. Also, the config documentation will be generated from these.
delasteve
force-pushed
the
feature/persist-ng-serve-options
branch
from
0905cff to
b32835a
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #1156