Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): hashes in prod builds now changes when ID change. #3609

Merged
merged 5 commits into from
Dec 19, 2016
Merged

fix(build): hashes in prod builds now changes when ID change. #3609

merged 5 commits into from
Dec 19, 2016

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Dec 17, 2016

Fixes #2868.
Fixes #3311.

@hansl hansl force-pushed the version-router branch 3 times, most recently from 3e6be90 to 521e4e7 Compare December 17, 2016 00:57
filipesilva
filipesilva suggested changes Dec 17, 2016
View reviewed changes
tests/e2e/tests/build/chunk-hash.ts
.then(() => {
fs.readdirSync('./dist')
.forEach(name => {
if (!name.match(/(main|inline|style|\d+)\.[a-z0-9]+\.bundle\.js/)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styles bundle should be dist/styles.[hash].bundle.css instead of dist/style.[hash].bundle.js.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@filipesilva
Copy link
Contributor

lgtm aside from the styles check.

@elvirdolic
Copy link

Amazing!!!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot
Copy link

CLAs look good, thanks!

@hansl hansl merged commit 8e9abf9 into angular:master Dec 19, 2016
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@hansl @MRHarrison
fix(build): hashes in prod builds now changes when ID change. (angula…
8e16184 
…r#3609)
@hansl hansl deleted the version-router branch August 2, 2018 19:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hash code not changing in inline.js file during build Wrong hashing for scripts production bundle
4 participants
@hansl @filipesilva @elvirdolic @googlebot