Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): update codegen API #2919

Merged
merged 2 commits into from
Oct 28, 2016
Merged

Conversation

robwormald
Copy link
Contributor

@robwormald robwormald commented Oct 27, 2016

fixes codegen API to support new transitiveModules dependency.

Fixes #2917.

@@ -239,7 +239,7 @@ export class AotPlugin {
return lazyRoutes;
}, {});
})
.then(() => cb(), (err) => cb(err));
.then(() => cb(), (err:any) => cb(err));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed linting because of no space after the :

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@Brocco
Copy link
Contributor

Brocco commented Oct 28, 2016

I signed it

@hansl hansl merged commit b50c121 into angular:master Oct 28, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AOT Build Errors with "Cannot read property 'transitiveModules' of undefined"
5 participants