feat: add aot option to karma #28854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjaaidi
commented
Nov 13, 2024
| }) | ||
| class Hello {} | ||
|
|
||
| expect((Hello as any).ɵcmp.template.toString()).not.toContain('jit'); |
There was a problem hiding this comment.
This is fragile and sensitive to any structural changes in JIT. It could easily cause false negatives.
What would be a better way to achieve this detection?
| ...BASE_OPTIONS, | ||
| aot: true, | ||
| /** Cf. {@link ../builder-mode_spec.ts} */ | ||
| polyfills: ['zone.js', '@angular/localize/init', 'zone.js/testing'], |
There was a problem hiding this comment.
Should we factorize this in BASE_OPTIONS? or create a BASE_POLYFILLS? or an object mother: optionsMother.base().withPolyfills()?
yjaaidi
force-pushed
the
feat/add-aot-option-to-karma
branch
from
38ac095
to
48d0a96
Compare
|
Sorry for the lack of review so far but I just want to quickly say that I'm really excited to see this option added. |
|
No rush at all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Tests run in JIT only.
What is the new behavior?
Tests can run in AOT, using the new
aotoption.Does this PR introduce a breaking change?
Other information