feat: add secondary entrypoint schematic #28723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
needs: discussion
|
Hi @alan-agius4 I saw that you added the discussion label. Any pointers what the discussion is about? I'm happy to join the discussion to see what we can improve or my point of view on things. |
|
@Jefiozie, since this is adding a new public API, we need to discuss this internally, and make sure that the team is on board with this. |
|
@alan-agius4 that does make sense, I will wait then and rebase this PR until you / the team comes back with feedback. |
Jefiozie
force-pushed
the
secondaryEntrypoint
branch
from
acc6219
to
6d617b8
Compare
|
@alan-agius4 the PR is up-to-date with latest changes |
Jefiozie
force-pushed
the
secondaryEntrypoint
branch
from
6d617b8
to
6392681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no easy way to generate a secondary entrypoint
Issue Number: #19070
What is the new behavior?
This PR adds the ability to generate a secondary entrypoint in a library project. It cannot be used without a library project.
Does this PR introduce a breaking change?
Other information
I've copied some helper utils from other schematics. I'm happy to make a other PR to add these to the utility parts with proper tests on it. Not updated the docs as this is I think in a other repo?
Pinging @SanderElias he mentioned there was nothing in the cli and encourage me to make this change 👍