feat(@angular/build): enable component stylesheet hot replacement by default #28646
+63
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
clydin
force-pushed
the
application/component-style-hmr
branch
from
7cf65cf
to
b5eb852
Compare
JoostK
reviewed
Oct 16, 2024
clydin
force-pushed
the
application/component-style-hmr
branch
from
b5eb852
to
656f5b8
Compare
dgp1130
approved these changes
Oct 16, 2024
| // TODO: Enable by default once full support across CLI and FW is integrated | ||
| browserOptions.externalRuntimeStyles = useComponentStyleHmr; | ||
| // Enable to support component style hot reloading (`NG_HMR_CSTYLES=0` can be used to disable) | ||
| browserOptions.externalRuntimeStyles = !!serverOptions.liveReload && useComponentStyleHmr; |
There was a problem hiding this comment.
Consider: Prefer Boolean(...) over !! to be more clear about your intent.
clydin
force-pushed
the
application/component-style-hmr
branch
from
656f5b8
to
3ea7e12
Compare
…default When using the `application` builder (default for new projects) with the development server, component style only changes will now automatically replace the styles within the running application without a full reload of the page. No application code changes are necessary and both file-based (`styleUrl`/`styleUrls`) and inline (`styles`) component styles are supported. Within a component template, `<style>` elements and `<link rel="stylesheet">` elements with relative `href` attributes are also supported. If any issues are encountered or it is preferred to not hot replace component styles, the `NG_HMR_CSTYLES=0` environment variable can be used to disable the feature. Setting the `liveReload` option to false will also disable all updates.
clydin
force-pushed
the
application/component-style-hmr
branch
from
3ea7e12
to
09e915f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
applicationbuilder (default for new projects) with the development server, component style only changes will now automatically replace the styles within the running application without a full reload of the page. No application code changes are necessary and both file-based (styleUrl/styleUrls) and inline (styles) component styles are supported. Within a component template,<style>elements and<link rel="stylesheet">elements with relativehrefattributes are also supported.If any issues are encountered or it is preferred to not hot replace component styles, the
NG_HMR_CSTYLES=0environment variable can be used to disable the feature. Setting theliveReloadoption to false will also disable all updates.