Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): include index.csr.html in resources asset group #28585

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

alan-agius4
Copy link
Collaborator

Ensure index.csr.html is available for the service worker when using SSR/SSG.

Closes #28574

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 7, 2024
… group

Ensure `index.csr.html` is available for the service worker when using SSR/SSG.

Closes angular#28574
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 7, 2024
@dgp1130 dgp1130 merged commit 7de93e5 into angular:main Oct 7, 2024
31 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Oct 7, 2024

The changes were merged into the following branches: main, 18.2.x

@alan-agius4 alan-agius4 deleted the csr-index branch October 7, 2024 16:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using Angular with SSR without prerender there is no index.html generated
3 participants