-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): add --verbose and --progress flags #2858
Conversation
fef3b15
to
02aa794
Compare
cbf5e02
to
c06b3b2
Compare
f9b5b8b
to
ff993ba
Compare
ff993ba
to
ad66341
Compare
Is this dead? It has been two versions released since this PR was submitted :) |
@victornoel not dead, but higher priorities have come up. |
@filipesilva can I do something to help? :) |
ad66341
to
1519b63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way too much copy paste. Can we make a configureWebpackOutputConfig()
(or whatever) with options passed in that is called by everyone that needs it, which in turn apply Progress and/or verbose according to arguments?
That way in the future when we move that code we won't have to look everywhere :)
|
||
const getWebpackTestConfig = function (projectRoot, environment, appConfig, testConfig) { | ||
|
||
const appRoot = path.resolve(projectRoot, appConfig.root); | ||
const extraRules = []; | ||
const extraPlugins = []; | ||
var extraRules = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, don't remember why I changed this at the time.
Currently builds output a lot of information, some of which can hide errors, by default. This PR cuts down on the information shown and adds a `--verbose` flag to restore previous build output. A `--progress` flag is also present to turn off progress logging in CI environments. Fix angular#1836 Fix angular#2012
73b8f58
to
14ead71
Compare
53e25bf
to
9327463
Compare
Way better. LGTM! |
Great to see that this feature landed. Any insight on when there will be a new release? :) |
* feat(build): add --verbose and --progress flags Currently builds output a lot of information, some of which can hide errors, by default. This PR cuts down on the information shown and adds a `--verbose` flag to restore previous build output. A `--progress` flag is also present to turn off progress logging in CI environments. Fix angular#1836 Fix angular#2012
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently builds output a lot of information, some of which can hide errors, by default.
This PR cuts down on the information shown and adds a
--verbose
flag to restore previous build output.A
--progress
flag is also present to turn off progress logging in CI environments.Example post PR:
Fix #1836
Fix #2012