feat(autoprefixer) Hook up autoprefixer for less, scss, and css. #2852
Conversation
SethDavenport
force-pushed
the
feat/autoprefixer
branch
from
d1cda0e to
d1fdade
Compare
SethDavenport
changed the title
SethDavenport
force-pushed
the
feat/autoprefixer
branch
2 times, most recently
from
39c41a1 to
6a93a52
Compare
|
Will fix tests soon :) Sorry... |
|
I'm not sure that code added in tests really needed. Or this code needed for autoprefixer testing? |
|
yes - I have a test that verifies that autoprefixer works for css files. however it should also happen at the end of the loader chain for less and scss too. I haven't had time to dig into the less/scss test infrastructure to see what I did wrong yet. I will get to it soon. |
SethDavenport
force-pushed
the
feat/autoprefixer
branch
from
6a93a52 to
4d99072
Compare
[Autoprefixer](https://github.com/postcss/autoprefixer) is a tool that uses data from caniuse.com to add vendor prefixes for styles that need them. It saves developers from having to manually prefix things, and is widely used these days. Since it's available as a postcss plugin, it makes sense to inlcude it in the angular-cli build step by default. This implementation uses the default browser targeting settings: last two versions, or whatever's in the user's project's [browserslist](https://github.com/ai/browserslist). Closes angular#1512.
SethDavenport
force-pushed
the
feat/autoprefixer
branch
from
4d99072 to
98abbd0
Compare
|
Rebased, now getting a new error: |
There was a problem hiding this comment.
Heya @SethDavenport, thanks for the PR! It LGTM and we should get around to merging it soon.
Don't worry too much about that chrome 53 error, it has nothing to do with your PR and was fixed in #2914
|
Awesome :) Thanks for the help on this one. |
|
Thanks for getting this in - just curious though - did I accidentally duplicate a PR from @renehamburger ? |
|
Uh, I kinda don't know what happened there. I might have botched the merge process when I did it in a batch... |
|
No worries - was just curious |
|
Hi there. Our team is really appreciating the efforts you did for getting Autoprefixer into the angular-cli. However, right now it seems we don't see it in our copy of beta 19-3. Is there something we are missing that needs to be done? |
|
@rokie83 it's merged after 19-3, and not released yet. All you can do is either try to work from CLI's git repo, or wait for the next release. This is sort of why I started the discussion about release frequency in #3127 |
[Autoprefixer](https://github.com/postcss/autoprefixer) is a tool that uses data from caniuse.com to add vendor prefixes for styles that need them. It saves developers from having to manually prefix things, and is widely used these days. Since it's available as a postcss plugin, it makes sense to inlcude it in the angular-cli build step by default. This implementation uses the default browser targeting settings: last two versions, or whatever's in the user's project's [browserslist](https://github.com/ai/browserslist). Closes angular#1512. Close angular#2852
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Autoprefixer is a tool that uses data from caniuse.com to add vendor prefixes for styles that need them. It saves developers from having to manually prefix things, and is widely used these days.
Since it's available as a postcss plugin, it makes sense to inlcude it in the angular-cli build step by default.
This implementation uses the default browser targeting settings: last two versions, or whatever's in the user's project's browserslist.
Closes #1512.