feat(@schematics/angular): use TypeScript module preserve option for new projects #28303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
|
There appears to be a TypeScript issue related to |
clydin
force-pushed
the
schematics/use-tsconfig-module-preserve
branch
from
722e30f
to
ff0771e
Compare
clydin
force-pushed
the
schematics/use-tsconfig-module-preserve
branch
from
ff0771e
to
094b1e9
Compare
clydin
force-pushed
the
schematics/use-tsconfig-module-preserve
branch
from
094b1e9
to
3b0dd49
Compare
…new projects Newly generated projects will now use the `preserve` value for the `module` option within the TypeScript configuration for the workspace (`tsconfig.json`). This value was added in TypeScript 5.4 and is intended to model the behavior of modern bundlers such as used in the default `application` builder. This option value also has the advantage of automatically enabling `esModuleInterop` and setting `moduleResolution` to `bundler` which are the currently generated values for new projects. This allows explicit use of these options to be removed from the generated file. The `resolveJsonModule` option is also enabled with `preserve` which removes the need for developers to manually add it if JSON files are imported. JSON file imports are fully support including unused property treeshaking with named imports in the `application` builder. Additional details on the option can be found here: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-4.html#support-for-require-calls-in---moduleresolution-bundler-and---module-preserve
clydin
force-pushed
the
schematics/use-tsconfig-module-preserve
branch
from
3b0dd49
to
a7f5b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly generated projects will now use the
preservevalue for themoduleoption within the TypeScript configuration for the workspace (tsconfig.json). This value was added in TypeScript 5.4 and is intended to model the behavior of modern bundlers such as used in the defaultapplicationbuilder. This option value also has the advantage of automatically enablingesModuleInteropand settingmoduleResolutiontobundlerwhich are the currently generated values for new projects. This allows explicit use of these options to be removed from the generated file. TheresolveJsonModuleoption is also enabled withpreservewhich removes the need for developers to manually add it if JSON files are imported. JSON file imports are fully support including unused property treeshaking with named imports in theapplicationbuilder.Additional details on the option can be found here:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-4.html#support-for-require-calls-in---moduleresolution-bundler-and---module-preserve