feat(build) use appConfig.index to set output index file #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollannikas
force-pushed
the
master
branch
2 times, most recently
from
d16e673 to
6211974
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Pass appConfig.index to the HtmlWebpackPlugin’s filename property. Closes angular#2241
|
CLAs look good, thanks! |
|
Looks good, thanks @hollannikas! Will merge soon. |
filipesilva
approved these changes
Oct 27, 2016
AnalogJ
added a commit
to AnalogJ/angular-cli
that referenced
this pull request
Nov 18, 2016
related to fix in angular#2767 There is no guarantee that there will be an `index.html` file, as the developer may specify a custom index file. When a developer uses a custom index file, use that file name when copying to the 404.html file.
This was referenced Nov 18, 2016
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
Pass appConfig.index to the HtmlWebpackPlugin’s filename property. Closes angular#2241 Closes angular#2767
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass appConfig.index to the HtmlWebpackPlugin’s filename property.
Closes #2241