fix(build): add react minification support #2754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
add-react-env
branch
from
e8408b0 to
77416bd
Compare
Brocco
approved these changes
Oct 18, 2016
grizzm0
reviewed
Oct 18, 2016
| @@ -24,6 +24,9 @@ export const getWebpackProdConfigPartial = function(projectRoot: string, appConf | |||
| }, | |||
| plugins: [ | |||
| new WebpackMd5Hash(), | |||
| new webpack.DefinePlugin({ | |||
| 'process.env.NODE_ENV': '\'production\'' | |||
There was a problem hiding this comment.
That looks a bit odd. Perhaps use JSON.stringify() instead?
There was a problem hiding this comment.
You're right, changing it.
filipesilva
force-pushed
the
add-react-env
branch
from
77416bd to
27b5b9f
Compare
|
@Brocco I also had to fix the node vars used by test builds and reduce duplication to ensure all builds had the same ones. |
filipesilva
added a commit
that referenced
this pull request
Oct 18, 2016
kieronqtran
pushed a commit
to kieronqtran/angular-cli
that referenced
this pull request
Oct 21, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2110