Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular-devkit/build-angular): update webpack-dev-middleware to 6.1.2 #27337

Merged
merged 3 commits into from
Mar 22, 2024
Merged

fix(@angular-devkit/build-angular): update webpack-dev-middleware to 6.1.2 #27337

merged 3 commits into from
Mar 22, 2024

Conversation

alan-agius4
Copy link
Collaborator

Addressed in this commit is an update to webpack-dev-middleware to version 6.1.2, resolving a security concern identified at GHSA-wr3j-pwj9-hqq6.

Closes #27334

@alan-agius4
fix(@angular-devkit/build-angular): update webpack-dev-middleware t…
79f391c 
…o `6.1.2`

Addressed in this commit is an update to `webpack-dev-middleware` to version `6.1.2`, resolving a security concern identified at GHSA-wr3j-pwj9-hqq6.

Closes angular#27334
@alan-agius4 alan-agius4 added the target: lts This PR is targeting a version currently in long-term support label Mar 22, 2024
@alan-agius4
test: disable failing test
1495326 
Disable test that is failing but not caused by this change

(cherry picked from commit b3803f4)
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 22, 2024
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer and removed area: build & ci Related the build and CI infrastructure of the project labels Mar 22, 2024
@alan-agius4 alan-agius4 requested a review from clydin March 22, 2024 08:00
@alan-agius4
Copy link
Collaborator Author

@clydin CI failures seems to be unrelated to this change

@alan-agius4
build: update ng-dev config to work with Node.js 18.19
190989b 
Update ng-dev setup to work with 18.19 For more details, refer to: TypeStrong/ts-node#2094

(cherry picked from commit a6129a6)
@alan-agius4 alan-agius4 force-pushed the webpack-middleware-fix-15 branch from cf57d08 to 190989b Compare March 22, 2024 08:18
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 22, 2024
@alan-agius4 alan-agius4 linked an issue Mar 22, 2024 that may be closed by this pull request
@angular-devkit/build-angular depends on vulnerable version of webpack-dev-middleware #27334
Closed
1 task
@alan-agius4 alan-agius4 removed a link to an issue Mar 22, 2024
@angular-devkit/build-angular depends on vulnerable version of webpack-dev-middleware #27334
Closed
1 task
@clydin clydin merged commit 61f92fd into angular:15.2.x Mar 22, 2024
20 of 21 checks passed
@alan-agius4 alan-agius4 deleted the webpack-middleware-fix-15 branch March 22, 2024 16:42
@alan-agius4 alan-agius4 mentioned this pull request Mar 22, 2024
Closed
1 task
@alan-agius4 alan-agius4 linked an issue Mar 22, 2024 that may be closed by this pull request
@angular-devkit/build-angular depends on vulnerable version of webpack-dev-middleware #27334
Closed
1 task
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 22, 2024
@ngbot
Copy link

ngbot bot commented Mar 22, 2024

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test-node14" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: lts This PR is targeting a version currently in long-term support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@angular-devkit/build-angular depends on vulnerable version of webpack-dev-middleware
2 participants
@alan-agius4 @clydin