Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): ignore supported browsers during i18n extraction #23421

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

alan-agius4
Copy link
Collaborator

Since extraction doesn't work on the browser we can ignore the supportedBrowsers configuration during message extraction.

Closes #23420

…i18n extraction

Since extraction doesn't work on the browser we can ignore the `supportedBrowsers` configuration during message extraction.

Closes angular#23420
@alan-agius4 alan-agius4 requested a review from clydin June 23, 2022 13:43
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jun 23, 2022
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 23, 2022
@dgp1130 dgp1130 merged commit 1fc7d4f into angular:main Jun 23, 2022
@alan-agius4 alan-agius4 deleted the i18n-extract branch June 23, 2022 17:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng extract-i18n: Cannot create property 'message' on string error -> depends on -browserlistrc configuration
3 participants