Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix(mobile): re-enable --mobile flag #2320

Closed
wants to merge 8 commits into from

Conversation

jeffbcross
Copy link
Contributor

@jeffbcross jeffbcross commented Sep 24, 2016

There are still some todos here, but opening it up in case anyone would like to start taking a look.

CC @gdi2290 @Brocco @filipesilva @hansl @alxhub

TODOs:

  • Re-enable mobile e2e tests
  • Move module definition out of main-app-shell.ts into app/app-shell.module.ts (make main-app-shell.ts similar to main.ts)
  • Clean up temporary directory created during ts compilation step
  • Replace the OfflinePlugin with Angular's Service Worker plugin
  • Generate manifest.json for Service Worker
  • Just pass 'index.html' from webpack-build-mobile.ts to the plugin, let the plugin resolve the path itself.

@hansl
Copy link
Contributor

hansl commented Sep 30, 2016

I'm not going to merge this until the tests are passing and the universal PR has been merged (with this PR rebased on top of it).

@jeffbcross
Copy link
Contributor Author

Closing this, will give some thought to our CLI integration.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants