feat(e2e): add ng e2e command #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
updated-e2e
branch
3 times, most recently
from
844c1fb to
4512686
Compare
filipesilva
changed the title
filipesilva
force-pushed
the
updated-e2e
branch
from
4512686 to
ccdbb8a
Compare
| @@ -1,4 +1,5 @@ | |||
| import "angular2/testing"; | |||
| /// <reference path="../typings/main.d.ts" /> | |||
There was a problem hiding this comment.
Actually, scratch that last comment.
|
LGTM. |
| ```bash | ||
| $(npm bin)/webdriver-manager update | ||
| $(npm bin)/tsc -p e2e/ | ||
| ng test |
There was a problem hiding this comment.
The command here should be ng e2e
There was a problem hiding this comment.
Good catch, thanks!
filipesilva
force-pushed
the
updated-e2e
branch
from
ccdbb8a to
351d797
Compare
|
LGTM |
filipesilva
force-pushed
the
updated-e2e
branch
from
351d797 to
e2e4f56
Compare
clydin
pushed a commit
that referenced
this pull request
Jun 5, 2018
…th static member access Fix #228
hansl
pushed a commit
that referenced
this pull request
Jun 6, 2018
…th static member access Fix #228
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.