feat(@angular-devkit/build-angular): validate file extensions for scripts and styles options
#22613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
alan-agius4
changed the title
scripts and styles optionsscripts and styles options
alan-agius4
changed the title
scripts and styles optionsscripts and styles options
dgp1130
approved these changes
Jan 31, 2022
packages/angular_devkit/build_angular/src/builders/browser/schema.json
Outdated
Show resolved
Hide resolved
…ripts` and `styles` options In some cases unexpected files may be provided which can cause to unsupported or broken behaviour. One such use-case is users can provide TypeScript files as `scripts` input, this would not be processed by the TypeScript compiler, see: #17125 and would cause the build to fail with a an unhelpful error message during optimization as the JS optimizers cannot parse TypeScript input. BREAKING CHANGE: `browser` and `karma` builders `script` and `styles` options input files extensions are now validated. Valid extensions for `scripts` are: - `.js` - `.cjs` - `.mjs` - `.jsx` - `.cjsx` - `.mjsx` Valid extensions for `styles` are: - `.css` - `.less` - `.sass` - `.scss` - `.styl`
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases unexpected files may be provided which can cause to unsupported or broken behaviour.
One such use-case is users can provide TypeScript files as
scriptsinput, this would not be processed by the TypeScript compiler, see: #17125 and would cause the build to fail with a an unhelpful error message during optimization as the JS optimizers cannot parse TypeScript input.BREAKING CHANGE:
Browser builder
scriptandstylesoptions input files extensions are now validated.Valid extensions for
scriptsare:.js.cjs.mjs.jsx.cjsx.mjsxValid extensions for
stylesare:.css.less.sass.scss.styl