Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): destroy test module after every test #21300

Merged
merged 1 commit into from
Jul 7, 2021
Merged

feat(@schematics/angular): destroy test module after every test #21300

merged 1 commit into from
Jul 7, 2021

Conversation

alan-agius4
Copy link
Collaborator

In version 12.1, the framework added the destroyAfterEach an opt-in feature that improves tests performance and also addresses two long-standing issues.

The idea, is to have this enabled by default in the future. Related PR: angular/angular#42566

Closes #21280

In version 12.1, the framework added the `destroyAfterEach` an opt-in feature that improves tests performance and also addresses two long-standing issues.

The idea, is to have this enabled by default in the future.  Related PR: angular/angular#42566

Closes #21280
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Jul 7, 2021
@google-cla google-cla bot added the cla: yes label Jul 7, 2021
@alan-agius4 alan-agius4 requested a review from clydin July 7, 2021 07:57
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jul 7, 2021
@clydin clydin merged commit 20fd33f into angular:master Jul 7, 2021
@alan-agius4 alan-agius4 deleted the destroyAfterEach branch July 7, 2021 14:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faster tests: Destroy test module after every test by default
2 participants