fix(@angular-devkit/build-angular): fix node 16 breaking when deleting the output path #21215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like it also is related, but since exceptions are ignored I don't think this change is needed |
…g the output path
According to `rmdirSync` [1] the `recursive` option is deprecated. The
wording looks like it was changed (compared to Node LTS [2]) to not
include anything about ignoring errors on paths not existing. In the
future the call should be `rmSync(..., {..., force: true})`, but when
testing locally adding a "force" option does not restore the previous
behavior. This isn't documented to work, but since the code original
code is deprecated I was wondering if the underlying functionality was
just passing all the options `rmSync` on Node 16.
This change includes an existence check to skip deleting a non existent
directory.
closes: angular#21216
[1]: https://nodejs.org/api/fs.html#fs_fs_rmdirsync_path_options
[2]: https://nodejs.org/docs/latest-v14.x/api/fs.html#fs_fs_rmdirsync_path_options
terencehonles
force-pushed
the
fix-node-16-breaking-on-init
branch
from
8afb687 to
a731b43
Compare
|
Duplicate of #21203 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
rmdirSync1 therecursiveoption is deprecated. The wording looks like it was changed (compared to Node LTS 2) to not include anything about ignoring errors on paths not existing. In the future the call should bermSync(..., {..., force: true}), but when testing locally adding a "force" option does not restore the previous behavior. This isn't documented to work, but since the code original code is deprecated I was wondering if the underlying functionality was just passing all the optionsrmSyncon Node 16.This change includes an existence check to skip deleting a non existent directory.
Fixes: #21216