chore: Adding a check for old version of the CLI #2116
Conversation
| import * as path from 'path'; | ||
|
|
||
|
|
||
| function _findUp(name: string, from: string) { |
There was a problem hiding this comment.
Why is this not a private static method inside the Version class?
| } | ||
|
|
||
|
|
||
| function _hasOldCliBuildFile() { |
There was a problem hiding this comment.
Why is this not a private static method inside the Version class?
There was a problem hiding this comment.
It doesn't access any class property/method, so it doesn't need to be a version.
hansl
changed the title
| @@ -42,6 +43,8 @@ const BuildCommand = Command.extend({ | |||
| } | |||
| } | |||
|
|
|||
| Version.assertPostWebpackVersion(); | |||
There was a problem hiding this comment.
This should not be only on builds, but on calls to ng. Testing and generators also have changed and assume post-webpack.
There was a problem hiding this comment.
Yes, sorry I forgot that. Let me fix.
| @@ -39,15 +39,15 @@ export class CliConfig extends CliConfigBase<ConfigInterface> { | |||
|
|
|||
|
|
|||
| static fromProject(): CliConfig { | |||
There was a problem hiding this comment.
This gives you the version the project was generated with, not the version it is currently using. You can only know that from the installed package.
There was a problem hiding this comment.
Good point, I'll fix.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.