fix(find-lazy-modules): Allow for any valid keys/value to be used #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and properly understand and return the modules in this case. Also refactored that function to be clearer, and added a test to cover. I made sure the test was failing before this PR ;) Fixes angular#1891, angular#1960. cc @filipesilva @ericjim @chalin - See similar angular#1972
hansl
force-pushed
the
fix-lazy-module
branch
2 times, most recently
from
1991700 to
b2aa24f
Compare
|
There's a small lint error but otherwise LGTM. |
hansl
force-pushed
the
fix-lazy-module
branch
from
b2aa24f to
49e32bc
Compare
catull
pushed a commit
to catull/angular-cli
that referenced
this pull request
Sep 6, 2016
…gular#1987) * fix(find-lazy-modules): Allow for any valid keys/value to be used and properly understand and return the modules in this case. Also refactored that function to be clearer, and added a test to cover. I made sure the test was failing before this PR ;) Fixes angular#1891, angular#1960. cc @filipesilva @ericjim @chalin - See similar angular#1972 * cleanup
|
@hansl : thanks for the fix! Must the value's of a {
'loadChildren': `app/{$foo}/settings.module#Module`
}; |
| 'loadChildren': 'moduleC' | ||
| }; | ||
| const r4 = { | ||
| "loadChildren": 'app/+workspace/+settings/settings.module#SettingsModule' |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and properly understand and return the modules in this case.
Also refactored that function to be clearer, and added a test to cover. I made sure the test was failing before this PR ;)
Fixes #1891, #1960.
cc @filipesilva @ericjim @chalin - See similar #1972