fix(@angular-devkit/build-optimizer): increase safety of code removal #19049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
safer-build-optimizer
branch
3 times, most recently
from
d381593 to
9722bd1
Compare
alan-agius4
reviewed
Oct 12, 2020
alan-agius4
reviewed
Oct 12, 2020
| getTransforms.push( | ||
| // getPrefixFunctionsTransformer is rather dangerous, apply only to known pure es5 modules. | ||
| // It will mark both `require()` calls and `console.log(stuff)` as pure. | ||
| // We only apply it to modules known to be side effect free, since we know they are safe. | ||
| // getPrefixFunctionsTransformer needs to be before getFoldFileTransformer. | ||
| getPrefixFunctionsTransformer, |
There was a problem hiding this comment.
Do we know for which cases the prefix function transformer is needed in Angular?
There was a problem hiding this comment.
View Engine factory files need it and were already included in the safe side effect check.
Additionally, there are a variety call/new expressions in @angular/* involving the following:
[
"ComponentFactoryResolver$1",
"InjectionToken",
"KeyRegistry",
"Optional",
"ObservableStrategy",
"PromiseStrategy",
"ReflectionCapabilities",
"Reflector",
"Version",
"core_merge",
"getClosureSafeProperty",
"makeDecorator",
"makeParamDecorator",
"makePropDecorator",
"tagSet",
"tokenKey",
]
alan-agius4
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
2 questions mainly.
And from the code changes, I am confident that this change also fixes #18621
This change lowers the potential for code to be errantly removed by the prefix functions and scrub file transformers. Only known safe modules are used with the prefix functions transformer as it can easily remove required module level side effects (as opposed to global level side effects) such as `__decorate` calls. The scrub file transformer will now keep metadata if non-Angular decorators are present. This allows libraries that use that information to continue to function. Closes angular#14033 Closes angular#18621
… tests The experimental Webpack Rollup pass no longer produces smaller sizes than the standard production build.
clydin
force-pushed
the
safer-build-optimizer
branch
from
9722bd1 to
6bfa224
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lowers the potential for code to be errantly removed by the prefix functions and scrub file transformers. Only known safe modules are used with the prefix functions transformer as it can easily remove required module level side effects (as opposed to global level side effects) such as
__decoratecalls.The scrub file transformer will now keep parameter metadata if non-Angular decorators are present. This allows libraries that use that information to continue to function.
Closes #14033
Closes #18621