Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): change extends from tsconfig.base.json to tsconfig.json #18540

Merged
merged 2 commits into from
Aug 17, 2020
Merged

fix(@schematics/angular): change extends from tsconfig.base.json to tsconfig.json #18540

merged 2 commits into from
Aug 17, 2020

Conversation

alan-agius4
Copy link
Collaborator

Closes: #18534

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Aug 15, 2020
@alan-agius4 alan-agius4 requested a review from clydin August 15, 2020 07:55
@Splaktar
Copy link
Member

Based on what I observed in #18534 (comment), I'm not sure that this is sufficient.

I still had comments in my tsconfig.json about it being a "Solution Style" tsconfig.json file and the contents of my tsconfig.base.json got deleted but not moved into my tsconfig.json.

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Aug 16, 2020

@Splaktar, it's because we where using the wrong JsonFile instance here: https://github.com/angular/angular-cli/pull/18540/files#diff-d1380d3bc19bb56c82d31f1222da33ecL63

This should solve that issue as well.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 17, 2020
@alan-agius4 alan-agius4 merged commit f3d54ee into angular:master Aug 17, 2020
@alan-agius4 alan-agius4 deleted the solutions-tsconfig-revert-fix branch August 17, 2020 16:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The build fails due to missing file after upgrade.
4 participants