-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@angular-devkit/build-angular): add webpack transformer to extract-i18n builder #16759
Conversation
Related issue: #16679 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add Closes: #16679
as the commit footer and address the lint issue?
Thanks.
…t-i18n builder Closes: angular#16679
Done |
Need to determine when the new i18n extraction method is coming up. Based on that timeline we can decided whether this PR should be done now or wait for the new infrastructure. |
@dgp1130 What do you mean with that?
|
@julmot, there's some infrastructure work coming up changing the way our i18n pipeline works. I don't know much more than that at the moment, so we just need to figure out the expected timeline for that work to understand whether it makes sense to do this work now or wait to integrate it with the new infra. I forget who told me they were looking into this. @clydin, who's the right person to talk to about the i18n pipeline? |
Sorry to ping @clydin, but I'd very much appreciate any progress here since I can't use xi18n currently due to the need of my custom webpack config. |
Is there anyone that could reply to @dgp1130's question? |
The new infrastructure work mentioned is based on this PR: angular/angular#32912 I need to work on this in the next few weeks, then it can be integrated into the CLI. |
@petebacondarwin Any news on this? Really need it. |
Is there any chance we can merge this? |
Superseded by #18613 and will be in 10.1.0. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The purpose of this PR is to add a Webpack configuration transformer in order to support i18n for custom webpack builds (3rd party builders).
More info here.