Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): add webpack transformer to extract-i18n builder #16759

Closed
wants to merge 1 commit into from

Conversation

just-jeb
Copy link

@just-jeb just-jeb commented Jan 26, 2020

The purpose of this PR is to add a Webpack configuration transformer in order to support i18n for custom webpack builds (3rd party builders).
More info here.

@julkue
Copy link

julkue commented Jan 26, 2020

Related issue: #16679

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add Closes: #16679 as the commit footer and address the lint issue?

Thanks.

@just-jeb just-jeb changed the title feat(@angular-devkit/build-angular): add webpack tranformer to extract-i18n builder feat(@angular-devkit/build-angular): add webpack transformer to extract-i18n builder Jan 27, 2020
@filipesilva filipesilva added target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 27, 2020
@just-jeb
Copy link
Author

Done

@alan-agius4 alan-agius4 added the needs: discussion On the agenda for team meeting to determine next steps label Jan 28, 2020
@dgp1130
Copy link
Collaborator

dgp1130 commented Feb 6, 2020

Need to determine when the new i18n extraction method is coming up. Based on that timeline we can decided whether this PR should be done now or wait for the new infrastructure.

@julkue
Copy link

julkue commented Feb 6, 2020

@dgp1130 What do you mean with that?

Need to determine when the new i18n extraction method is coming up

@dgp1130
Copy link
Collaborator

dgp1130 commented Feb 7, 2020

@julmot, there's some infrastructure work coming up changing the way our i18n pipeline works. I don't know much more than that at the moment, so we just need to figure out the expected timeline for that work to understand whether it makes sense to do this work now or wait to integrate it with the new infra.

I forget who told me they were looking into this. @clydin, who's the right person to talk to about the i18n pipeline?

@julkue
Copy link

julkue commented Feb 18, 2020

Sorry to ping @clydin, but I'd very much appreciate any progress here since I can't use xi18n currently due to the need of my custom webpack config.

@clydin clydin removed the needs: discussion On the agenda for team meeting to determine next steps label Feb 20, 2020
@julkue
Copy link

julkue commented Mar 7, 2020

Is there anyone that could reply to @dgp1130's question?

@petebacondarwin
Copy link
Contributor

The new infrastructure work mentioned is based on this PR: angular/angular#32912

I need to work on this in the next few weeks, then it can be integrated into the CLI.

@julkue
Copy link

julkue commented Apr 20, 2020

@petebacondarwin Any news on this? Really need it.

@julkue
Copy link

julkue commented Jun 5, 2020

Is there any chance we can merge this?

@clydin clydin removed their assignment Aug 27, 2020
@clydin
Copy link
Member

clydin commented Aug 27, 2020

Superseded by #18613 and will be in 10.1.0.

@clydin clydin closed this Aug 27, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants