Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change inline-source-map to source-map for dev and common builds. #1659

Merged

Conversation

TheLarkInn
Copy link
Member

Fixes #1519 where either a chrome or webpack issue is causing inline-source-map and cheap-module-source-map to display inaccurately for development and production mode (in some cases).

@hansl
Copy link
Contributor

hansl commented Aug 12, 2016

LGTM

@filipesilva filipesilva merged commit e0454e3 into angular:master Aug 12, 2016
@masaanli
Copy link

Awesome 👍

@TheLarkInn
Copy link
Member Author

Also fixes #1490

@masaanli
Copy link

masaanli commented Aug 12, 2016

I can confirm that it is fixed, but the build times are now twice as slow at my side :) But still workable. 2 seconds for each change as build time.

@mmrath
Copy link
Contributor

mmrath commented Aug 16, 2016

It still does not work I think. simple ng new project is fine but once I add material2 ng serve throws error. If I revert the source-map change then it works. More details at #1490 (comment)

@brendanalexdr
Copy link

I am getting this debug/mapping mal-config problem too. The debugging was working fine for a while, but after my app got to a critical mass (like around 20 components) it has started to get wonkie: breakpoints won't hit, or impossible to set breakpoint (off by x number of lines)

angular-cli: 1.0.0-beta.18
node: 6.7.0
os: win32 x64

NPM: 3.10.8
OS: Windows 10 x64
Chrome: 54.0.2840.71 m (64-bit)

@filipesilva
Copy link
Contributor

@nukuuk in beta.18 we have a sourcemap issue, but it will be fixed in beta.19

@brendanalexdr
Copy link

@filipesilva installed beta.19, and am still having problems setting breakpoints :(

@filipesilva filipesilva deleted the bugfix/make_sourcemaps_great_again branch November 3, 2016 15:44
@filipesilva filipesilva restored the bugfix/make_sourcemaps_great_again branch November 3, 2016 15:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugging not working well in Webpack Branch
7 participants