Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): add CanDeactivate guard #16195

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Nov 14, 2019

This generates a generic CanDeactivate<unknown> guard.

Fixes #15668

This generates a generic `CanDeactivate<unknown>` guard.

Fixes angular#15668
@cexbrayat cexbrayat force-pushed the fix/15668-can-deactivate branch from e59368e to 2a53e03 Compare November 14, 2019 15:21
@cexbrayat cexbrayat requested a review from clydin November 14, 2019 15:21
@clydin clydin added the target: patch This PR is targeted for the next patch release label Nov 14, 2019
@dgp1130 dgp1130 merged commit 2fc3fab into angular:master Nov 14, 2019
@dgp1130
Copy link
Collaborator

dgp1130 commented Nov 14, 2019

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to implement CanDeactivate interface while generating a guard
4 participants