-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move environment files to config
directory
#1611
fix: move environment files to config
directory
#1611
Conversation
Why this change?? |
We are not removing it, but simply moving it from an |
@TheLarkInn Thanks, I was asking why we are moving 3 environment files to app directory. I thought it was good inside From #1603 it looks like this change is required for NgModule support which should be fine. |
Yup! This is a 'looking-forward' change for ngmodules. |
app
directoryconfig
directory
cb678d1
to
dc77ec6
Compare
Closed in favor of #1633. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Move environment configuration files from
environments
directory toconfig
directory. Also bumped webpack beta to .20 (chore).This allows for free movement of app [or using multiple apps] without affecting/needing to change environment paths imports/exports.
Fixes #1603