Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move environment files to config directory #1611

Conversation

TheLarkInn
Copy link
Member

@TheLarkInn TheLarkInn commented Aug 9, 2016

Move environment configuration files from environments directory to config directory. Also bumped webpack beta to .20 (chore).

This allows for free movement of app [or using multiple apps] without affecting/needing to change environment paths imports/exports.
Fixes #1603

@tapas4java
Copy link
Contributor

Why this change??
Are we fixing any particular issue by removing environment directory?

@TheLarkInn
Copy link
Member Author

We are not removing it, but simply moving it from an environments folder to an app folder like the above comments mention. This fixes #1603

@tapas4java
Copy link
Contributor

@TheLarkInn Thanks, I was asking why we are moving 3 environment files to app directory. I thought it was good inside environment directory as user can add few more environments later.

From #1603 it looks like this change is required for NgModule support which should be fine.

@TheLarkInn
Copy link
Member Author

TheLarkInn commented Aug 9, 2016

Yup! This is a 'looking-forward' change for ngmodules.

@TheLarkInn TheLarkInn changed the title fix: move environment files to app directory fix: move environment files to config directory Aug 9, 2016
@TheLarkInn TheLarkInn force-pushed the feature/move_envrionment_files_to_app_directory branch from cb678d1 to dc77ec6 Compare August 9, 2016 20:04
@filipesilva
Copy link
Contributor

Closed in favor of #1633.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move environments to the app directory
4 participants