fix(@angular-devkit/build-angular): allow localization with development server #16053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
target: patch
clydin
force-pushed
the
ng-serve-i18n
branch
7 times, most recently
from
6a93776 to
41e52ba
Compare
filipesilva
suggested changes
Nov 7, 2019
| @@ -40,7 +40,7 @@ function emittedFilesToInlineOptions( | |||
| es5, | |||
| outputPath, | |||
| missingTranslation, | |||
| setLocale: emittedFile.name === 'main', | |||
| setLocale: emittedFile.name === 'main' || emittedFile.name === 'vendor', | |||
There was a problem hiding this comment.
Is it possible for the locale to need to be set in lazy chunks?
There was a problem hiding this comment.
From the point of view of Angular, we only need to set it in main.js so that we can pick it up in Angular services and pipes. And I guess, since it is global, that once it is set it will automatically be available to all lazy loaded chunks.
There was a problem hiding this comment.
Then what's the situation where it needs to be set in vendor?
filipesilva
approved these changes
Nov 8, 2019
mgechev
pushed a commit
that referenced
this pull request
Nov 8, 2019
…nt server (#16053) * fix(@angular-devkit/build-angular): allow localization with development server * test: ensure i18n application E2E tests are executed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.