feat(@schematics/angular): add migration ensure that tslib is insta…
#15800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
clydin
approved these changes
Oct 9, 2019
|
|
||
| export function addTsLib(): Rule { | ||
| return host => { | ||
| removePackageJsonDependency(host, 'tslib'); |
There was a problem hiding this comment.
Is this to ensure it is not a dev dep?
IgorMinar
referenced
this pull request
in angular/angular
Oct 15, 2019
BREAKING CHANGE: We no longer directly have a direct depedency on `tslib`. Instead it is now listed a `peerDependency`. Users not using the CLI will need to manually install `tslib` via; ``` yarn add tslib ``` or ``` npm install tslib --save ``` PR Close #32167
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lled
Related to: angular/angular#32167