Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor: deprecate protractor baseUrl option from builder" #13953

Closed
wants to merge 1 commit into from
Closed

Revert "refactor: deprecate protractor baseUrl option from builder" #13953

wants to merge 1 commit into from

Conversation

krotscheck
Copy link

This reverts commit 5415bcc.

Right now, this is flagged as "Deprecated" in the CLI, which isn't actually the case. As per the new protractor implementation in a49d278 , baseUrl is supported as long as devServerTarget is not included.

This patch reverts the deprecation note.

Resolves #13952

This reverts commit 5415bcc.
@alan-agius4
Copy link
Collaborator

Thanks for this, however kindly see #13952 (comment)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

baseUrl flag in protractors schema is deprecated
3 participants