Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular-devkit/build-optimizer): don't add pure comments inside … #13871

Merged
merged 1 commit into from
Mar 11, 2019
Merged

fix(@angular-devkit/build-optimizer): don't add pure comments inside … #13871

merged 1 commit into from
Mar 11, 2019

Conversation

alan-agius4
Copy link
Collaborator

…arrow functions

Fixes #13768

@alan-agius4 alan-agius4 requested a review from filipesilva March 11, 2019 13:52
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed cla: yes labels Mar 11, 2019
@googlebot

This comment has been minimized.

Sign in to view
filipesilva
filipesilva approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work getting to the bottom of this!

@vikerman vikerman merged commit b32ad32 into angular:master Mar 11, 2019
@alan-agius4 alan-agius4 deleted the build-optimizer-arrow-function branch March 11, 2019 21:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build optimization breaks my library code
4 participants
@alan-agius4 @googlebot @filipesilva @vikerman