Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): respect preserveSymlinks when using bundleDependencies in server builder #13819

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Mar 5, 2019

  • fix(@angular-devkit/build-angular): don't bundle linked modules when bundleDependencies in none in server builder

Fixes #13817

@alan-agius4 alan-agius4 changed the title wip: universal link wip fix(@angular-devkit/build-angular): respect preserveSymlinks when using bundleDependencies in server builder Mar 5, 2019
@alan-agius4 alan-agius4 marked this pull request as ready for review March 5, 2019 13:25
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Mar 5, 2019
@alan-agius4 alan-agius4 requested a review from clydin March 5, 2019 15:27
@alan-agius4 alan-agius4 requested a review from clydin March 6, 2019 14:14
…`bundleDependencies` in `none` in server builder

Fixes #13817
@hansl hansl merged commit 309b483 into angular:master Mar 6, 2019
@alan-agius4 alan-agius4 deleted the fix-universal-linking branch March 6, 2019 19:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build of server side bundle is combining to the bundle packages which are linked.
4 participants