fix(@schematics/angular): Add types to AppPage in e2e #13406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When app.po.ts is compiled under Bazel with Typescript 3.2,
AppPage produces the following error:
e2e/src/app.po.ts:4:3 - error TS2742: The inferred type of 'navigateTo' cannot be named without a reference to '../../external/npm/node_modules/@types/selenium-webdriver/index'. This is likely not portable. A type annotation is necessary.
4 navigateTo() {
~~~~~~~~~~
e2e/src/app.po.ts:8:3 - error TS2742: The inferred type of 'getTitleText' cannot be named without a reference to '../../external/npm/node_modules/@types/selenium-webdriver/index'. This is likely not portable. A type annotation is necessary.
8 getTitleText() {
~~~~~~~~~~~~
kyliau
added a commit
to kyliau/angular
that referenced
this pull request
Jan 11, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406
kyliau
added a commit
to kyliau/angular
that referenced
this pull request
Jan 11, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406
alexeagle
approved these changes
Jan 11, 2019
kyliau
added a commit
to kyliau/angular
that referenced
this pull request
Jan 11, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406
kyliau
added a commit
to kyliau/angular
that referenced
this pull request
Jan 11, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406
kyliau
added a commit
to kyliau/angular
that referenced
this pull request
Jan 12, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Jan 12, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406 PR Close #28061
petebacondarwin
pushed a commit
to petebacondarwin/angular
that referenced
this pull request
Jan 14, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406 PR Close angular#28061
kyliau
added a commit
to kyliau/angular
that referenced
this pull request
Jan 14, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406
14 tasks
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Jan 15, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406 PR Close #28142
AndrewKushnir
pushed a commit
to angular/angular
that referenced
this pull request
Jan 16, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406 PR Close #28142
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Jan 18, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406 PR Close angular#28061
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Jan 18, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406 PR Close angular#28061
kyliau
pushed a commit
to kyliau/angular-cli
that referenced
this pull request
Jan 23, 2019
This is a cherry-pick of dc2e40a Original PR: angular#13406 When app.po.ts is compiled under Bazel with Typescript 3.2, AppPage produces the following error: e2e/src/app.po.ts:4:3 - error TS2742: The inferred type of 'navigateTo' cannot be named without a reference to '../../external/npm/node_modules/@types/selenium-webdriver/index'. This is likely not portable. A type annotation is necessary. 4 navigateTo() { ~~~~~~~~~~ e2e/src/app.po.ts:8:3 - error TS2742: The inferred type of 'getTitleText' cannot be named without a reference to '../../external/npm/node_modules/@types/selenium-webdriver/index'. This is likely not portable. A type annotation is necessary. 8 getTitleText() { ~~~~~~~~~~~~
mgechev
pushed a commit
that referenced
this pull request
Jan 23, 2019
This is a cherry-pick of dc2e40a Original PR: #13406 When app.po.ts is compiled under Bazel with Typescript 3.2, AppPage produces the following error: e2e/src/app.po.ts:4:3 - error TS2742: The inferred type of 'navigateTo' cannot be named without a reference to '../../external/npm/node_modules/@types/selenium-webdriver/index'. This is likely not portable. A type annotation is necessary. 4 navigateTo() { ~~~~~~~~~~ e2e/src/app.po.ts:8:3 - error TS2742: The inferred type of 'getTitleText' cannot be named without a reference to '../../external/npm/node_modules/@types/selenium-webdriver/index'. This is likely not portable. A type annotation is necessary. 8 getTitleText() { ~~~~~~~~~~~~
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
The current integration test for Bazel schematics downloads a published version of Angular as required by the http_archive rule in the CLI created WORKSPACE. However, this makes the test less useful because it does not actually test any changes to the Angular repo at source. This PR replaces the http_archive method in the WORSPACE with local_repository so that any local changes to the Angular repo are tested accordingly. With Typescript 3.2, the file e2e/src/app.po.ts generated by CLI no longer compiles under Bazel due to missing type annotations. A temporary file is placed in the integration/bazel-schematics directory while the change is pending in CLI repo. angular/angular-cli#13406 PR Close angular#28061
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When app.po.ts is compiled under Bazel with Typescript 3.2,
AppPage produces the following error:
e2e/src/app.po.ts:4:3 - error TS2742: The inferred type of 'navigateTo' cannot be named without a reference to '../../external/npm/node_modules/@types/selenium-webdriver/index'. This is likely not portable. A type annotation is necessary.
4 navigateTo() {
~~~~~~~~~~
e2e/src/app.po.ts:8:3 - error TS2742: The inferred type of 'getTitleText' cannot be named without a reference to '../../external/npm/node_modules/@types/selenium-webdriver/index'. This is likely not portable. A type annotation is necessary.
8 getTitleText() {
~~~~~~~~~~~~