Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/schematics): upgrade using tslint output has too … #12715

Merged
merged 1 commit into from
Oct 31, 2018
Merged

fix(@angular-devkit/schematics): upgrade using tslint output has too … #12715

merged 1 commit into from
Oct 31, 2018

Conversation

alan-agius4
Copy link
Collaborator

…much whitespace

Fixes #12653

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Oct 23, 2018
@alan-agius4 alan-agius4 removed the request for review from filipesilva October 24, 2018 04:43
@devversion
Copy link
Member

Based on my testing, unnecessary whitespace also shows up if there were failures/replacements that have been reported by the given rules.

Shouldn't we always trim the output?

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Oct 24, 2018

At least it didn’t bother me of having an empty line at the end but than seeing it’s in the refactor makes sense to always trim.

@kyliau kyliau merged commit b38a13d into angular:master Oct 31, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI Upgrade output has too much whitespace
5 participants